Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add policy schema display #1289

Merged
merged 7 commits into from
May 2, 2023
Merged

feat: add policy schema display #1289

merged 7 commits into from
May 2, 2023

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Apr 6, 2023 •
edited
Loading

Rendered

Closes #1274

@netlify
Copy link

netlify bot commented Apr 6, 2023 •
edited
Loading

✅ Deploy Preview for kuma ready!

Name Link
🔨 Latest commit 7a0f8f4
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/645100121f18e80008999473
😎 Deploy Preview https://deploy-preview-1289--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@michaelbeaumont michaelbeaumont force-pushed the feat/policy_schema branch 4 times, most recently from 9749749 to e709b33 Compare April 12, 2023 13:35
@michaelbeaumont michaelbeaumont marked this pull request as ready for review April 12, 2023 13:40
@michaelbeaumont michaelbeaumont requested review from a team, Automaat and bartsmykla and removed request for a team April 12, 2023 13:40
@lahabana lahabana marked this pull request as draft April 12, 2023 14:20
@lahabana
Copy link
Contributor

Putting this as draft as we need to extract this to make it usable in both doc sites.

lahabana
lahabana reviewed Apr 12, 2023
View reviewed changes
sync_generated.sh Outdated Show resolved Hide resolved
app/_plugins/tags/policyschema.rb Outdated Show resolved Hide resolved
app/_plugins/tags/policyschema.rb Outdated Show resolved Hide resolved
sync_generated.sh Outdated Show resolved Hide resolved
@michaelbeaumont michaelbeaumont force-pushed the feat/policy_schema branch 2 times, most recently from 0840f59 to e00f6d8 Compare April 12, 2023 16:42
@lahabana lahabana mentioned this pull request Apr 13, 2023
Merged
@michaelbeaumont michaelbeaumont marked this pull request as ready for review April 26, 2023 11:40
@michaelbeaumont michaelbeaumont requested review from lahabana and removed request for lahabana April 26, 2023 11:47
bartsmykla
bartsmykla approved these changes Apr 28, 2023
View reviewed changes
app/_src/policies/meshcircuitbreaker.md Outdated Show resolved Hide resolved
@michaelbeaumont
docs: change section name
1e3680b 
Signed-off-by: Mike Beaumont <[email protected]>
lahabana
lahabana approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we can always do better later. One nit is that we don't have the 2.2.x policies synced

@michaelbeaumont
chore: sync 2.2 policies
cb937f1 
Signed-off-by: Mike Beaumont <[email protected]>
@michaelbeaumont michaelbeaumont mentioned this pull request May 2, 2023
Closed
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) May 2, 2023 12:20
@michaelbeaumont michaelbeaumont merged commit 590f66e into kumahq:master May 2, 2023
@michaelbeaumont michaelbeaumont deleted the feat/policy_schema branch May 2, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

@bartsmykla bartsmykla bartsmykla approved these changes

@Automaat Automaat Awaiting requested review from Automaat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Render JSONSchema from policies inside the docs
3 participants
@michaelbeaumont @lahabana @bartsmykla