Skip to content

Commit

Permalink
fix(Mesh*Route): make behavior clearer (#1496)
Browse files Browse the repository at this point in the history
* fix(Mesh*Route): make behavior clearer

explain that you need to keep route-all by default and
that MeshHTTPRoute takes priority over MeshTCPRoute

Signed-off-by: Charly Molter <[email protected]>
  • Loading branch information
lahabana authored Dec 11, 2023
1 parent f079b1f commit 600b16f
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
6 changes: 5 additions & 1 deletion app/_src/policies/meshhttproute.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ title: Mesh HTTP Route

{% warning %}
This policy uses new policy matching algorithm.
Do **not** combine with [TrafficRoute](/docs/{{ page.version }}/policies/traffic-route).
Do **not** combine with [TrafficRoute](/docs/{{ page.version }}/policies/traffic-route) except for the default `route-all` route, which should be kept..
{% endwarning %}

The `MeshHTTPRoute` policy allows altering and redirecting HTTP requests
Expand Down Expand Up @@ -114,6 +114,10 @@ them in a `MeshHTTPRoute`!
- **`weight`** - when a request matches the route, the choice of an upstream cluster
is determined by its weight. Total weight is a sum of all weights in `backendRefs` list.

## Interactions with `MeshTCPRoute`

`MeshHTTPRoute` takes priority over [`MeshTCPRoute`](../meshtcproute) when both are defined for the same service, and the matching `MeshTCPRoute` is ignored.

## Examples

### Traffic split
Expand Down
5 changes: 4 additions & 1 deletion app/_src/policies/meshtcproute.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ title: MeshTCPRoute

{% warning %}
This policy uses a new policy matching algorithm.
Do **not** combine with [TrafficRoute](/docs/{{ page.version }}/policies/traffic-route).
Do **not** combine with [TrafficRoute](/docs/{{ page.version }}/policies/traffic-route) except for the default `route-all` route, which should be kept.
{% endwarning %}

The `MeshTCPRoute` policy allows you to alter and redirect TCP requests
Expand Down Expand Up @@ -53,6 +53,9 @@ The following describes the default configuration settings of the `MeshTCPRoute`
cluster is determined by its weight. Total weight is a sum of all weights
in the `backendRefs` list.

## Interactions with `MeshHTTPRoute`

[`MeshHTTPRoute`](../meshhttproute) takes priority over `MeshTCPRoute` when both are defined for the same service, and the matching `MeshTCPRoute` is ignored.

## Examples

Expand Down

0 comments on commit 600b16f

Please sign in to comment.