-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump @kong/kongponents from 9.16.1 to 9.18.4 #3460
chore(deps): Bump @kong/kongponents from 9.16.1 to 9.18.4 #3460
Conversation
Bumps [@kong/kongponents](https://github.com/Kong/kongponents) from 9.16.1 to 9.18.3. - [Release notes](https://github.com/Kong/kongponents/releases) - [Changelog](https://github.com/Kong/kongponents/blob/main/CHANGELOG.md) - [Commits](Kong/kongponents@v9.16.1...v9.18.3) --- updated-dependencies: - dependency-name: "@kong/kongponents" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Top/bottom padding removal is necessary. Fixes #3438 (review) Signed-off-by: John Cowen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also requires #3462
### current master (I couldn't manage to get a grab with rollover, but it underlines): ![Screenshot 2025-01-24 at 14 23 55](https://github.com/user-attachments/assets/1174fabb-e5e7-45ee-afec-df4ec3769fde) ### With #3460 applied (the mouse is rolled over the link but the pointer isn't in the grab): ![Screenshot 2025-01-24 at 14 18 00](https://github.com/user-attachments/assets/8b096d74-d29c-4ce6-beff-3285e3e73933) ### With this PR applied (the mouse is rolled over the link but the pointer isn't in the grab): ![Screenshot 2025-01-24 at 14 17 08](https://github.com/user-attachments/assets/3a65998b-59fb-4f4b-9697-095c3072063d) Introduced in Kong/kongponents#2585 I've mentioned a few times I kinda have a different approach to solve this sort of stuff completely, I might put up a draft PR soon. Related to: - Kong/kongponents#2559 - #3323 - #3317 --------- Signed-off-by: John Cowen <[email protected]>
it underlines): ![Screenshot 2025-01-24 at 14 23 55](https://github.com/user-attachments/assets/1174fabb-e5e7-45ee-afec-df4ec3769fde) is rolled over the link but the pointer isn't in the grab): ![Screenshot 2025-01-24 at 14 18 00](https://github.com/user-attachments/assets/8b096d74-d29c-4ce6-beff-3285e3e73933) pointer isn't in the grab): ![Screenshot 2025-01-24 at 14 17 08](https://github.com/user-attachments/assets/3a65998b-59fb-4f4b-9697-095c3072063d) Introduced in Kong/kongponents#2585 I've mentioned a few times I kinda have a different approach to solve this sort of stuff completely, I might put up a draft PR soon. Related to: - Kong/kongponents#2559 - #3323 - #3317 --------- Signed-off-by: John Cowen <[email protected]>
335c1ad
to
7f3567d
Compare
A newer version of @kong/kongponents exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Yeah this is good to go, it was failing for ages and I couldn't figure out why e.g. https://github.com/kumahq/kuma-gui/actions/runs/12951815138/job/36133085811), seems to be green now tho so yep good to go! Oh hold up, according to the package-lock this has installed two versions of kongponents? weird 🤔 |
Ah maybe because of the manual bump commit somehow? If you temporarily remove that last commit does it stay green? |
Signed-off-by: schogges <[email protected]>
35fed8f
to
4a66c4d
Compare
Hmmm, super weird. I've tried again via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for sorting this!
Bumps @kong/kongponents from 9.16.1 to 9.18.3.
Release notes
Sourced from
@kong/kongponents
's releases.... (truncated)
Changelog
Sourced from
@kong/kongponents
's changelog.... (truncated)
Commits
c081e4e
chore(release): 9.18.3 [skip ci]9c3171a
fix(stylelint): add spacing rules (#2591)f3a2cd2
chore(release): 9.18.2 [skip ci]7ff96d2
fix(kselect, kmultiselect): filtered arrow navigation [KHCP-13956] (#2573)26dcce3
chore(deps): update dependency eslint to ^9.18.0 (#2590)936984e
chore(release): 9.18.1 [skip ci]382282a
fix(ktreelist): collapse handle click behavior (#2589)5d68b6b
chore(release): 9.18.0 [skip ci]a5490a3
feat(ktreelist): add collapse/expand option [KHCP-14716] (#2583)1f449d6
chore(deps): update dependency@vueuse/core
to v12 (#2537)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)