Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix release/prune which runs before make install #3412

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Jan 17, 2025

Follow up of #3410


Turns out npm query requires your node_modules to be present, I've no idea why 🤷 , and we have a target that we sometimes run that needs to run before a make install (make release/prune) 🤦 .

I saw that you can add a npm --package-lock-file-only query to get it to use the lock file instead of needing access to node_modules. This works when running from workspace root without node_modules, but when you run a Makefile from a sub project without node_modules adding this arg/flag still fails 🤷

I've fallen back to just jq-ing the package-lock.json myself at least for the moment so we can unblock the release workflow. If I find a slightly nicer way to do this in the future I'll replace, but I really want to stick to the runtime resolution of things rather than hardcoding paths in several files.

How to test:

  • Run make clean to remove all your node_modules folders
  • cd into or use make -C to run make release/prune from within packages/kuma-gui
  • Verify that packages/config has changes to package.json and package-lock.json also has changes.

I 'think' this will finally unblock the release workflow 🤞


edit: I just checked a this new approach actually works better elsewhere also 🎉

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit f95d9fb
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/678a7439f150d8000824a4a0
😎 Deploy Preview https://deploy-preview-3412--kuma-gui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johncowen johncowen marked this pull request as ready for review January 17, 2025 16:09
@johncowen johncowen requested a review from a team as a code owner January 17, 2025 16:09
@johncowen johncowen requested review from schogges and removed request for a team January 17, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant