-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: globally fix text color of buttons in alerts #3323
Conversation
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: John Cowen <[email protected]>
4bb68e8
to
2b8f0db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch 👍 also happy to see further adoption of variant
🙂
FYI I had/still have another branch which takes a completely different approach and makes it impossible for these things to happen at all (this PR only fixes primary buttons within a KAlert). It's an interesting branch/piece of work, so might put it up anyway to share. Would be good to chat with someone about it whether we wanted to use it or not (I'm not totally convinced yet myself). |
Signed-off-by: John Cowen <[email protected]>
Ah, I found out how to access existence of Will leave this hanging a little while longer here in case, but will merge later today if I hear no more. |
Ah, yeah that is good to know 👍 |
### current master (I couldn't manage to get a grab with rollover, but it underlines): ![Screenshot 2025-01-24 at 14 23 55](https://github.com/user-attachments/assets/1174fabb-e5e7-45ee-afec-df4ec3769fde) ### With #3460 applied (the mouse is rolled over the link but the pointer isn't in the grab): ![Screenshot 2025-01-24 at 14 18 00](https://github.com/user-attachments/assets/8b096d74-d29c-4ce6-beff-3285e3e73933) ### With this PR applied (the mouse is rolled over the link but the pointer isn't in the grab): ![Screenshot 2025-01-24 at 14 17 08](https://github.com/user-attachments/assets/3a65998b-59fb-4f4b-9697-095c3072063d) Introduced in Kong/kongponents#2585 I've mentioned a few times I kinda have a different approach to solve this sort of stuff completely, I might put up a draft PR soon. Related to: - Kong/kongponents#2559 - #3323 - #3317 --------- Signed-off-by: John Cowen <[email protected]>
it underlines): ![Screenshot 2025-01-24 at 14 23 55](https://github.com/user-attachments/assets/1174fabb-e5e7-45ee-afec-df4ec3769fde) is rolled over the link but the pointer isn't in the grab): ![Screenshot 2025-01-24 at 14 18 00](https://github.com/user-attachments/assets/8b096d74-d29c-4ce6-beff-3285e3e73933) pointer isn't in the grab): ![Screenshot 2025-01-24 at 14 17 08](https://github.com/user-attachments/assets/3a65998b-59fb-4f4b-9697-095c3072063d) Introduced in Kong/kongponents#2585 I've mentioned a few times I kinda have a different approach to solve this sort of stuff completely, I might put up a draft PR soon. Related to: - Kong/kongponents#2559 - #3323 - #3317 --------- Signed-off-by: John Cowen <[email protected]>
Fixes text color of all primary buttons within alerts.
See Kong/kongponents@84a4e9f
I previously "fixed" this in #3317 just for our upgrade button, thinking this was the only instance
This PR undoes that ^ PR and fixes it globally instead, which will fix the issue for all instances whether I remember about them or not.
Before
After