Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump @kong/kongponents from 9.14.16 to 9.14.17 #3249

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 2, 2024

Bumps @kong/kongponents from 9.14.16 to 9.14.17.

Release notes

Sourced from @​kong/kongponents's releases.

v9.14.17

9.14.17 (2024-11-26)

Bug Fixes

  • kalert: slotted links default styling [KHCP-14152] (#2528) (631a287)
  • ktableview: row-expanded prop and event [KHCP-14243] (#2527) (eb92309)
Changelog

Sourced from @​kong/kongponents's changelog.

9.14.17 (2024-11-26)

Bug Fixes

  • kalert: slotted links default styling [KHCP-14152] (#2528) (631a287)
  • ktableview: row-expanded prop and event [KHCP-14243] (#2527) (eb92309)
Commits
  • 9dd3e03 chore(release): 9.14.17 [skip ci]
  • eb92309 fix(ktableview): row-expanded prop and event [KHCP-14243] (#2527)
  • 631a287 fix(kalert): slotted links default styling [KHCP-14152] (#2528)
  • a941be5 chore(deps): update dependency @​kong-ui-public/sandbox-layout to ^2.1.59 (#2525)
  • d7ae829 chore(deps): update dependency @​vue/tsconfig to ^0.6.0 (#2524)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner December 2, 2024 23:40
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 2, 2024
@dependabot dependabot bot requested review from johncowen and removed request for a team December 2, 2024 23:40
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit e23a36f
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/674ef0dbf0b8c8000817c20d
😎 Deploy Preview https://deploy-preview-3249--kuma-gui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Bumps [@kong/kongponents](https://github.com/Kong/kongponents) from 9.14.16 to 9.14.17.
- [Release notes](https://github.com/Kong/kongponents/releases)
- [Changelog](https://github.com/Kong/kongponents/blob/main/CHANGELOG.md)
- [Commits](Kong/kongponents@v9.14.16...v9.14.17)

---
updated-dependencies:
- dependency-name: "@kong/kongponents"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/kong/kongponents-9.14.17 branch from 72f7941 to e23a36f Compare December 3, 2024 11:51
@johncowen
Copy link
Contributor

johncowen commented Dec 3, 2024

If you look at the upstream changes you'll see the links should be dark yellow text on lighter yellow background for warning alerts. We have blue text on yellow backgrounds currently (see PR preview on this PR)

So I think we should remove whatever is making our links in alerts blue. (and also as a side note, a historical discussion about making sure all our links are blue is even less of an concern)

Erm, I suppose we could merge this and then follow up, but if we don't do the work at the same time we should make an issue to track this. In fact I'll merge this and make an issue to track this as it formalizes the decision around the fact we don't need to make all our links blue.

@johncowen
Copy link
Contributor

johncowen commented Dec 3, 2024

Made an issue so I'm happy to merge this as is #3260

@johncowen johncowen merged commit 859095e into master Dec 3, 2024
16 checks passed
@johncowen johncowen deleted the dependabot/npm_and_yarn/kong/kongponents-9.14.17 branch December 3, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant