fix(search): Always show search bars #3089
Draft
+286
−256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncowen
commented
Oct 23, 2024
| :row="row as Row" | ||
| :row-value="rowValue" | ||
| /> | ||
| </template> |
There was a problem hiding this comment.
We no longer need the toolbar slot within AppCollection
| @@ -1,7 +1,7 @@ | |||
| <template> | |||
| <KInput | |||
| :model-value="props.value" | |||
| @input="(e: string) => e.length === 0 ? emit('change', e) : change(e)" | |||
There was a problem hiding this comment.
I noticed that on hitting Escape on the input field the length would be zero, meaning the non-debounced change would fire. This would cause a tiny UX issue with the text in the field. So I decided to remove the check for "" in order to fire a debounced change.
Signed-off-by: John Cowen <[email protected]>
johncowen
force-pushed
the
fix/search-bars
branch
from
855e34d
to
e4ab0eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hoists all search/toolbars out of AppCollection and the DataLoader/Collections to its own "standalone component". Meaning it is always visible, throughout loading/erroneous and empty states.
There is a little CSS repetition here, but I hope to add a XLayout component pretty soon which I hope will cover this at some point.
Note I also took the
<search>out ofFilterBarand used it at the "call site" instead, in some places thesearchshould contains theselectalso.Closes #2981