chore(ci): rename GUI PR GHA to "release" #3047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
johncowen
force-pushed
the
chore/auto-release
branch
29 times, most recently
from
5b34c3b to
a89f886
Compare
johncowen
force-pushed
the
chore/auto-release
branch
7 times, most recently
from
0ed3cda to
811916e
Compare
|
@lahabana showed me a button in the GH UI that does exactly what this PR does 😆 , so a lot of this PR is no longer needed. There are some bits here that I'd like to keep, mostly the renaming of "Create GUI PR" to "Release". We'd also like to improve the "release" PRs to include more changelog information. For the moment I'm going to put this back into draft. While I re-jiggle this about a bit. |
johncowen
force-pushed
the
chore/auto-release
branch
from
811916e to
f00273a
Compare
johncowen
changed the title
Signed-off-by: John Cowen <[email protected]>
johncowen
force-pushed
the
chore/auto-release
branch
from
f00273a to
2b905d1
Compare
slonka
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changed our "Create GUI PR" workflow:
release.yaml/Build and release to kumahq/kumabecause we are releasing the GUI to the binary/kuma. "Create GUI PR" sounds like I am creating a PR onkumahq/kuma-gui2. Added arepository-datajob that fetches all "topics" from the repository3. Uses therepository-dataoutput to look for aauto-release"topic" which when present (as it is currently) performs a "release" as before.I plan on merging this with theauto-release"topic" applied to prove it works (validate the PR is made). I will then remove theauto-releasetopic temporarily.Notes:I "think" I can't access the secrets in a run because I'm PRing from a forked PR, hence will currently fail until this is onmaster. I would level a better way to test this out (and GH Actions as a whole really) edit: I confirmed offline that my guess here is right.In this PR we have two calls to get the GH token. One during the actual "release" and one to have permissions to access the repo topics. I plan on reusing the one in therepository-datajob across the entire workflow once this PR is merged and we know it works as expected 🤞edit: See comment below, but TLDR; this PR now pretty much just renames the workflow action:
release.yaml/Build and release to kumahq/kumabecause we are releasing the GUI to the binary/kuma. "Create GUI PR" sounds like I am creating a PR onkumahq/kuma-gui