Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement #135: Move linking to frontend #157

Merged
merged 20 commits into from
Sep 19, 2023
Merged

Conversation

SOF3
Copy link
Member

@SOF3 SOF3 commented Aug 11, 2023

Description

Related issues

See #135

Special notes for your reviewer:

@SOF3 SOF3 changed the title refactor!: rename zconstants.NestLevel to PseudoType Implement #135 Aug 11, 2023
@SOF3 SOF3 changed the title Implement #135 Implement #135: Move linking to frontend Aug 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Patch coverage: 72.79% and project coverage change: +5.63% 🎉

Comparison is base (aa3bd12) 36.82% compared to head (cac7ecc) 42.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
+ Coverage   36.82%   42.45%   +5.63%     
==========================================
  Files          33       40       +7     
  Lines        2626     3380     +754     
==========================================
+ Hits          967     1435     +468     
- Misses       1596     1851     +255     
- Partials       63       94      +31     
Files Changed Coverage Δ
pkg/frontend/backend/interface.go 26.66% <0.00%> (ø)
pkg/frontend/tf/config/config.go 10.00% <0.00%> (ø)
pkg/util/object/key.go 11.32% <ø> (+6.32%) ⬆️
pkg/util/reflect/reflect.go 83.33% <0.00%> (-16.67%) ⬇️
pkg/util/zconstants/zconstants.go 0.00% <0.00%> (ø)
pkg/frontend/tf/config/link_selector.go 14.28% <14.28%> (ø)
pkg/frontend/tf/tree/tree.go 48.22% <68.57%> (ø)
pkg/util/zconstants/link.go 76.19% <76.19%> (ø)
pkg/frontend/reader/merge/merge.go 81.81% <81.81%> (ø)
pkg/util/semaphore/semaphore.go 87.05% <85.71%> (-1.41%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SOF3 SOF3 marked this pull request as ready for review August 18, 2023 08:51
@SOF3 SOF3 requested a review from xuqingyun August 18, 2023 08:52
@SOF3 SOF3 enabled auto-merge September 19, 2023 04:28
@SOF3 SOF3 merged commit 04c542d into kubewharf:main Sep 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants