Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add policy type to metadata #368

Merged
merged 2 commits into from
Oct 25, 2023
Merged

feat: add policy type to metadata #368

merged 2 commits into from
Oct 25, 2023

Conversation

fabriziosestito
Copy link
Contributor

Description

Adds policyType (kubernetes/raw, defaults to kubernetes) to the Policy metadata.

Test

yes

Additional Information

@fabriziosestito fabriziosestito requested a review from a team as a code owner October 25, 2023 12:47
@fabriziosestito fabriziosestito self-assigned this Oct 25, 2023
viccuad
viccuad approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@viccuad viccuad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would prefer to explicitly add policyType: kubernetes to the metadata_backwards_compatibility line 385.

flavio
flavio reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I agree with @viccuad's comment

src/policy_artifacthub.rs Outdated Show resolved Hide resolved
@fabriziosestito fabriziosestito force-pushed the feat/add-policy-type-metadata branch from 8086300 to 57f8365 Compare October 25, 2023 14:45
flavio
flavio approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having implemented the suggestion

@fabriziosestito fabriziosestito merged commit 00b814d into kubewarden:main Oct 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viccuad viccuad viccuad approved these changes

@flavio flavio flavio approved these changes

Assignees

@fabriziosestito fabriziosestito

Labels
None yet
Projects
Kubewarden
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziosestito @flavio @viccuad