feat: Expand install msg on artifacthub #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
viccuad
commented
Jul 14, 2023
src/policy_artifacthub.rs
Outdated
| @@ -375,6 +375,10 @@ fn compose_install(oci_url: String) -> String { | |||
| ```console | |||
| kwctl pull {} | |||
| ``` | |||
| Then, generate the policy manifest and tune it to your liking. For example: | |||
| ```console | |||
| kwctl scaffold manifest -t ClusterAdmissionPolicy registry://{} | |||
There was a problem hiding this comment.
Note that here I needed to add registry:// while for kwctl pull one doesn't need to.
Opened kubewarden/kwctl#537. Maybe worth fixing it at the same time as this for simplicity.
viccuad
force-pushed
the
install-artifacthub
branch
from
efc5274 to
4f0c357
Compare
flavio
approved these changes
Jul 17, 2023
src/policy_artifacthub.rs
Outdated
| "#, | ||
| oci_url | ||
| oci_url, oci_url |
There was a problem hiding this comment.
I would change the way we build this string to make use of the new string interpolation used by latest versions of rust. I think it would make things more readable:
Do something like
kwctl scaffold manifest -t ClusterAdmissionPolicy registry://{oci_url}
So that we can drop the line referenced by this comment
There was a problem hiding this comment.
TIL, amended the commit.
jvanz
approved these changes
Jul 17, 2023
viccuad
force-pushed
the
install-artifacthub
branch
from
4f0c357 to
efc5274
Compare
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
viccuad
force-pushed
the
install-artifacthub
branch
from
2caac07 to
595d381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I find the install modal on artifacthub lacking:
https://artifacthub.io/packages/kubewarden/safe-annotations/safe-annotations?modal=install
This is an attempt to improve it, as I was typing too much on my own.
Test
Additional Information
Tradeoff
Potential improvement