Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): set prerelease and latest flag properly. #224

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

jvanz
Copy link
Member

@jvanz jvanz commented Mar 13, 2024

Description

The release.yml is not properly setting the release as prerelease or latest release because the field used to check if the tag is a prerelease was not populated. This commit fixes that using another field.

Fix kubewarden/kubewarden-controller#657

@jvanz jvanz self-assigned this Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.80%. Comparing base (3ff6349) to head (319a6ef).

❗ Current head 319a6ef differs from pull request most recent head 0e64ac2. Consider uploading reports for the commit 0e64ac2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   72.80%   72.80%           
=======================================
  Files           6        6           
  Lines         662      662           
=======================================
  Hits          482      482           
  Misses        117      117           
  Partials       63       63           
Flag Coverage Δ
unit-tests 72.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The release.yml is not properly setting the release as prerelease or
latest release because the field used to check if the tag is a
prerelease was not populated. This commit fixes that using another
field.

Signed-off-by: José Guilherme Vanz <[email protected]>
@jvanz jvanz force-pushed the prerelease_latest_flag branch from 319a6ef to 0e64ac2 Compare March 13, 2024 21:14
@jvanz jvanz marked this pull request as ready for review March 13, 2024 21:45
@jvanz jvanz requested a review from a team as a code owner March 13, 2024 21:45
@viccuad viccuad merged commit fc92c19 into kubewarden:main Mar 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

CI is not properly tagging releases as latest
2 participants