-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parallel audit requests #220
feat: parallel audit requests #220
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
==========================================
+ Coverage 72.37% 72.80% +0.43%
==========================================
Files 6 6
Lines 637 662 +25
==========================================
+ Hits 461 482 +21
- Misses 115 117 +2
- Partials 61 63 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This is going to be part of the final 1.11 release CC @brunorene |
This fixes #217 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This feels more a feature than a fix, for it appear as such in the GH release it is enough to change the PR title. |
Signed-off-by: Fabrizio Sestito <[email protected]>
c023a04
to
8d19288
Compare
Description
This PR implements parallel audit requests to the policy server.
The parallelism is currently set to 100 requests, but in the future, we could expose this value to the user through the CLI so that it can be tuned.
Gnu time output
Before the fix on a cluster with ~300 resources and 15 policies:
After the fix
In the case of slower policies (for instance policies using context-aware capabilities) is safe to assume that the elapsed time difference should be higher.