Merge pull request #214 from jvanz/issue212

fix(report): Result field is optional.

internal/report/report.go

@@ -132,7 +132,11 @@ func newPolicyReportResult(policy policiesv1.Policy, admissionReview *admissionv
 	}
 
 	var message string
-	if !errored {
+	// We need to check if Result is not nil because this field is
+	// optional. If the policy returns "allowed" to the admissionReview,
+	// the Result field is not checked by Kubernetes.
+	// https://pkg.go.dev/k8s.io/[email protected]/admission/v1#AdmissionResponse
+	if !errored && admissionReview.Response.Result != nil {
 		message = admissionReview.Response.Result.Message
 	}
 

internal/report/report_test.go

@@ -137,7 +137,7 @@ func TestNewPolicyReportResult(t *testing.T) {
 			amissionReview: &admissionv1.AdmissionReview{
 				Response: &admissionv1.AdmissionResponse{
 					Allowed: true,
-					Result:  &metav1.Status{Message: "The request was allowed"},
+					Result:  nil,
 				},
 			},
 			errored: false,
@@ -149,7 +149,7 @@ func TestNewPolicyReportResult(t *testing.T) {
 				Timestamp:       now,
 				Scored:          true,
 				SubjectSelector: &metav1.LabelSelector{},
-				Description:     "The request was allowed",
+				Description:     "",
 				Properties: map[string]string{
 					PropertyPolicyUID:             "policy-uid",
 					propertyPolicyResourceVersion: "1",

internal/scanner/scanner_test.go

@@ -33,9 +33,7 @@ func newMockPolicyServer() *httptest.Server {
 		admissionReview := admissionv1.AdmissionReview{
 			Response: &admissionv1.AdmissionResponse{
 				Allowed: true,
-				Result: &metav1.Status{
-					Message: "The request was allowed",
-				},
+				Result:  nil,
 			},
 		}
 		response, err := json.Marshal(admissionReview)