Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUMA: Remove FG precondition and add v1.4 GA note #835

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lyarwood
Copy link
Member

What this PR does / why we need it:

FG GA'd by the following PR kubevirt/kubevirt#12232

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Sep 11, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jean-edouard for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@aburdenthehand aburdenthehand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lyarwood
I can't comment on this line but: Opening para "NUMA support in KubeVirt is at this stage limited to a small set of special use-cases and will improve over time together with improvements made to
Kubernetes."
Is that still true or has it improved since it was introduced?

Comment on lines +16 to +19
**FEATURE STATE:** KubeVirt v1.4 GA

The `NUMA` feature gate is now deprecated and as such enabled by default. The following [preconditions](#preconditions) still apply however.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in place of line 3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to retain the history of the feature thus the additional block.

We've not introduced any additional strategies yet but the existing functionality is mature enough that it doesn't require the feature gate anymore.

Copy link
Member Author

@lyarwood lyarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lyarwood I can't comment on this line but: Opening para "NUMA support in KubeVirt is at this stage limited to a small set of special use-cases and will improve over time together with improvements made to Kubernetes." Is that still true or has it improved since it was introduced?

That's still true, the decision to graduate feature gate however is more about maturity of the existing functionality. This original comment is still accurate and I think is still useful context in the docs.

Comment on lines +16 to +19
**FEATURE STATE:** KubeVirt v1.4 GA

The `NUMA` feature gate is now deprecated and as such enabled by default. The following [preconditions](#preconditions) still apply however.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to retain the history of the feature thus the additional block.

We've not introduced any additional strategies yet but the existing functionality is mature enough that it doesn't require the feature gate anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants