-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NUMA: Remove FG precondition and add v1.4 GA note #835
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Lee Yarwood <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lyarwood
I can't comment on this line but: Opening para "NUMA support in KubeVirt is at this stage limited to a small set of special use-cases and will improve over time together with improvements made to
Kubernetes."
Is that still true or has it improved since it was introduced?
**FEATURE STATE:** KubeVirt v1.4 GA | ||
|
||
The `NUMA` feature gate is now deprecated and as such enabled by default. The following [preconditions](#preconditions) still apply however. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in place of line 3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to retain the history of the feature thus the additional block.
We've not introduced any additional strategies yet but the existing functionality is mature enough that it doesn't require the feature gate anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lyarwood I can't comment on this line but: Opening para "NUMA support in KubeVirt is at this stage limited to a small set of special use-cases and will improve over time together with improvements made to Kubernetes." Is that still true or has it improved since it was introduced?
That's still true, the decision to graduate feature gate however is more about maturity of the existing functionality. This original comment is still accurate and I think is still useful context in the docs.
**FEATURE STATE:** KubeVirt v1.4 GA | ||
|
||
The `NUMA` feature gate is now deprecated and as such enabled by default. The following [preconditions](#preconditions) still apply however. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to retain the history of the feature thus the additional block.
We've not introduced any additional strategies yet but the existing functionality is mature enough that it doesn't require the feature gate anymore.
What this PR does / why we need it:
FG GA'd by the following PR kubevirt/kubevirt#12232
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: