US Tests - Creation of VM from Template tests #2377
Conversation
lkladnit
force-pushed
the
create-vm-template
branch
from
aff814a to
a5f0867
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkladnit, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
lkladnit
force-pushed
the
create-vm-template
branch
from
a5f0867 to
831c173
Compare
|
New changes are detected. LGTM label has been removed. |
lkladnit
force-pushed
the
create-vm-template
branch
4 times, most recently
from
a08a395 to
330ffb4
Compare
|
/retest |
lkladnit
force-pushed
the
create-vm-template
branch
from
330ffb4 to
e0f6093
Compare
|
/retest |
lkladnit
force-pushed
the
create-vm-template
branch
from
e0f6093 to
6184313
Compare
| @@ -24,7 +25,7 @@ Cypress.Commands.add('login', (provider: string, username: string, password: str | |||
| // Make sure we clear the cookie in case a previous test failed to logout. | |||
| cy.clearCookie('openshift-session-token'); | |||
|
|
|||
| cy.get('[data-test-id=login]', { timeout: 30000 }).should('be.visible'); | |||
| cy.get('[data-test-id=login]', { timeout: 5 * MINUTE }).should('be.visible'); | |||
There was a problem hiding this comment.
how about creating a const called TIMEOUT which will be a value of 5 * MINUTE, and if needed change in the future we can fix it in one place instead of multiple places
cypress/support/nav.ts
Outdated
| 'be.visible', | ||
| ); | ||
| Cypress.Commands.add('visitTemplatesVirt', () => { | ||
| // cy.clickVirtLink(nav.templateNav); |
There was a problem hiding this comment.
there are a lot of lines commented out in this file, is it intentional?
| @@ -56,8 +59,8 @@ Cypress.Commands.add('byTestOperatorRow', (selector: string, options?: object) = | |||
| cy.get(`[data-test-operator-row="${selector}"]`, options), | |||
| ); | |||
| Cypress.Commands.add('clickNavLink', (path: [string, string?]) => { | |||
| cy.byTestID('nav', { timeout: 10000 }) | |||
| .contains(path[0], { timeout: 10000 }) | |||
| cy.byTestID('nav', { timeout: 10 * SECOND }) | |||
There was a problem hiding this comment.
here too, 10 * SECOND repeats itself, how about creating another const, SHORT_TIMEOUT?
| @@ -88,3 +91,13 @@ Cypress.Commands.add('clickApplyBtn', () => cy.contains('button[type="button"]', | |||
| Cypress.Commands.add('switchToVirt', () => { | |||
| switchPerspective(Perspective.Virtualization); | |||
| }); | |||
|
|
|||
| Cypress.Commands.add('checkTitle', (title: string, timeout?: number) => { | |||
| const t_o = timeout ? timeout : 3 * MINUTE; | |||
There was a problem hiding this comment.
why here it's 3 minutes timeout and some files it's 5 minutes?
| @@ -2,11 +2,11 @@ | |||
|
|
|||
| set -eExuo pipefail | |||
|
|
|||
| source cleanup.sh | |||
| #source cleanup.sh | |||
lkladnit
force-pushed
the
create-vm-template
branch
from
12fc959 to
2376dae
Compare
|
/retest |
lkladnit
force-pushed
the
create-vm-template
branch
from
2376dae to
e27e01e
Compare
|
/retest |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
/retest |
|
/retest |
lkladnit
force-pushed
the
create-vm-template
branch
from
e27e01e to
d031009
Compare
|
/retest-required |
|
@lkladnit: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
📝 Description
It also disables switching to Virtualization Perspective and clones navigation functions used in Admin perspective to the same for Virtualization Perspective.