-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-52394: storage migration status #2373
CNV-52394: storage migration status #2373
Conversation
@upalatucci: This pull request references CNV-52394 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
46ec9fe
to
bde4164
Compare
depending on #2368 |
bde4164
to
59b4dde
Compare
59b4dde
to
d017680
Compare
...rtualmachines/actions/components/VirtualMachineMigration/VirtualMachineMigrationRollback.tsx
Outdated
Show resolved
Hide resolved
...virtualmachines/actions/components/VirtualMachineMigration/VirtualMachineMigrationStatus.tsx
Outdated
Show resolved
Hide resolved
import useVirtualMachineInstanceMigration from '@kubevirt-utils/resources/vmi/hooks/useVirtualMachineInstanceMigration'; | ||
|
||
const useCurrentStorageMigration = (vm: V1VirtualMachine) => { | ||
const [migrationStartedTime] = useState(new Date()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
u sure u need state here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can be a ref.
I can't do a const
outside the hook because it will run when this code is important but not executed.
I need the date when it's executed ( the migration start )
d017680
to
ad3c95c
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
After clicking on Migrate, the modal will show the status and let the user decide if wants to rollback the migration
🎥 Demo