-
Notifications
You must be signed in to change notification settings - Fork 35
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #2392 from upalatucci/fix-instancetype-messages
CNV-53272:Refactor instancetype vm creation create button
- Loading branch information
Showing
7 changed files
with
246 additions
and
122 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import React, { FC, ReactNode } from 'react'; | ||
|
|
||
| import { Tooltip, TooltipPosition } from '@patternfly/react-core'; | ||
|
|
||
| type HidableTooltipProps = { | ||
| children: ReactNode; | ||
| content: ReactNode; | ||
| hidden: boolean; | ||
| position?: TooltipPosition; | ||
| }; | ||
|
|
||
| const HidableTooltip: FC<HidableTooltipProps> = ({ | ||
| children, | ||
| content, | ||
| hidden, | ||
| position = TooltipPosition.right, | ||
| }) => { | ||
| return hidden ? ( | ||
| <>{children}</> | ||
| ) : ( | ||
| <Tooltip content={content} position={position}> | ||
| <>{children}</> | ||
| </Tooltip> | ||
| ); | ||
| }; | ||
|
|
||
| export default HidableTooltip; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 108 additions & 0 deletions
108
...ateFromInstanceTypes/components/CreateVMFooter/components/ActionButtons/ActionButtons.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| import React, { FC, useCallback } from 'react'; | ||
| import { useNavigate } from 'react-router-dom-v5-compat'; | ||
| import { VirtualMachineModel } from 'src/views/dashboard-extensions/utils'; | ||
|
|
||
| import { useInstanceTypeVMStore } from '@catalog/CreateFromInstanceTypes/state/useInstanceTypeVMStore'; | ||
| import HidableTooltip from '@kubevirt-utils/components/HidableTooltip/HidableTooltip'; | ||
| import { logITFlowEvent } from '@kubevirt-utils/extensions/telemetry/telemetry'; | ||
| import { CANCEL_CREATE_VM_BUTTON_CLICKED } from '@kubevirt-utils/extensions/telemetry/utils/constants'; | ||
| import { useKubevirtTranslation } from '@kubevirt-utils/hooks/useKubevirtTranslation'; | ||
| import { getResourceUrl } from '@kubevirt-utils/resources/shared'; | ||
| import { useActiveNamespace } from '@openshift-console/dynamic-plugin-sdk'; | ||
| import { | ||
| Button, | ||
| ButtonVariant, | ||
| Split, | ||
| SplitItem, | ||
| Stack, | ||
| TooltipPosition, | ||
| } from '@patternfly/react-core'; | ||
|
|
||
| import useStatusActionButtons from './useStatusActionButtons'; | ||
|
|
||
| type ActionButtonsProps = { | ||
| isSubmitting?: boolean; | ||
| onCreate: () => void; | ||
| onCustomize: () => void; | ||
| onViewYAML: () => void; | ||
| }; | ||
|
|
||
| const ActionButtons: FC<ActionButtonsProps> = ({ | ||
| isSubmitting = false, | ||
| onCreate, | ||
| onCustomize, | ||
| onViewYAML, | ||
| }) => { | ||
| const navigate = useNavigate(); | ||
|
|
||
| const [activeNamespace] = useActiveNamespace(); | ||
|
|
||
| const { t } = useKubevirtTranslation(); | ||
|
|
||
| const { | ||
| instanceTypeVMState: { vmName }, | ||
| } = useInstanceTypeVMStore(); | ||
|
|
||
| const onCancel = useCallback(() => { | ||
| logITFlowEvent(CANCEL_CREATE_VM_BUTTON_CLICKED, null, { vmName: vmName }); | ||
| navigate(getResourceUrl({ activeNamespace, model: VirtualMachineModel })); | ||
| }, [activeNamespace, navigate, vmName]); | ||
|
|
||
| const { disableButtonTooltipContent, isCreationDisabled, isViewYAMLDisabled } = | ||
| useStatusActionButtons(isSubmitting); | ||
|
|
||
| return ( | ||
| <Split hasGutter> | ||
| <SplitItem> | ||
| <HidableTooltip | ||
| content={<Stack>{disableButtonTooltipContent}</Stack>} | ||
| hidden={!isCreationDisabled} | ||
| position={TooltipPosition.top} | ||
| > | ||
| <Button | ||
| isAriaDisabled={isCreationDisabled} | ||
| isLoading={isSubmitting} | ||
| onClick={onCreate} | ||
| variant={ButtonVariant.primary} | ||
| > | ||
| {t('Create VirtualMachine')} | ||
| </Button> | ||
| </HidableTooltip> | ||
| </SplitItem> | ||
| <SplitItem> | ||
| <HidableTooltip | ||
| content={<Stack>{disableButtonTooltipContent}</Stack>} | ||
| hidden={!isCreationDisabled} | ||
| position={TooltipPosition.top} | ||
| > | ||
| <Button | ||
| isDisabled={isCreationDisabled} | ||
| isLoading={isSubmitting} | ||
| onClick={onCustomize} | ||
| variant={ButtonVariant.secondary} | ||
| > | ||
| {t('Customize VirtualMachine')} | ||
| </Button> | ||
| </HidableTooltip> | ||
| </SplitItem> | ||
|
|
||
| <SplitItem> | ||
| <Button onClick={onCancel} variant={ButtonVariant.link}> | ||
| {t('Cancel')} | ||
| </Button> | ||
| </SplitItem> | ||
| <SplitItem isFilled /> | ||
| <SplitItem> | ||
| <Button | ||
| isDisabled={isViewYAMLDisabled} | ||
| onClick={onViewYAML} | ||
| variant={ButtonVariant.secondary} | ||
| > | ||
| {t('View YAML & CLI')} | ||
| </Button> | ||
| </SplitItem> | ||
| </Split> | ||
| ); | ||
| }; | ||
|
|
||
| export default ActionButtons; |
Oops, something went wrong.