fix: delete useless code

Signed-off-by: FogDong <[email protected]>
kubevela · Aug 13, 2024 · 8ba50b3 · 8ba50b3
1 parent 074a471
commit 8ba50b3
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 63 deletions.
diff --git a/.github/workflows/unit-test.yaml b/.github/workflows/unit-test.yaml
@@ -66,7 +66,7 @@ jobs:
         with:
           version: 3.1.0
           kubebuilderOnly: false
-          kubernetesVersion: v1.21.2
+          kubernetesVersion: v1.28.0
 
       - name: Run Make test
         run: make test

diff --git a/makefiles/const.mk b/makefiles/const.mk
@@ -4,7 +4,7 @@ IMG_TAG ?= latest
 OS      ?= linux
 ARCH    ?= amd64
 # ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
-ENVTEST_K8S_VERSION = 1.24.1
+ENVTEST_K8S_VERSION = 1.28.0
 
 # Get the currently used golang install path (in GOPATH/bin, unless GOBIN is set)
 ifeq (,$(shell go env GOBIN))

diff --git a/pkg/cue/model/value/value_test.go b/pkg/cue/model/value/value_test.go
@@ -109,45 +109,6 @@ func TestFieldPath(t *testing.T) {
 	}
 }
 
-// func TestValueFix(t *testing.T) {
-// 	testCases := []struct {
-// 		original string
-// 		expected string
-// 	}{
-// 		{
-// 			original: `
-// parameter: test: _
-// // comment
-// y: {
-// 	for k, v in parameter.test.p {
-// 		"\(k)": v
-// 	}
-// }`,
-// 			expected: `{
-// 	parameter: {
-// 		test: _
-// 	}
-// 	// comment
-// 	y: {
-// 		for k, v in *parameter.test.p | {} {
-// 			"\(k)": v
-// 		}
-// 	}
-// }`,
-// 		},
-// 	}
-// 	for i, tc := range testCases {
-// 		t.Run(fmt.Sprint(i), func(t *testing.T) {
-// 			r := require.New(t)
-// 			v, err := NewValue(tc.original, nil, "")
-// 			r.NoError(err)
-// 			b, err := format.Node(v.CueValue().Syntax(cue.Docs(true)))
-// 			r.NoError(err)
-// 			r.Equal(tc.expected, string(b))
-// 		})
-// 	}
-// }
-
 func TestSetByScript(t *testing.T) {
 	testCases := []struct {
 		name     string

diff --git a/pkg/providers/legacy/util/util_test.go b/pkg/providers/legacy/util/util_test.go
@@ -272,17 +272,6 @@ func TestLog(t *testing.T) {
 	}
 }
 
-// func TestInstall(t *testing.T) {
-// 	p := providers.NewProviders()
-// 	pCtx := process.NewContext(process.ContextData{})
-// 	pCtx.PushData(model.ContextStepName, "test-step")
-// 	Install(p, pCtx)
-// 	h, ok := p.GetHandler("util", "string")
-// 	r := require.New(t)
-// 	r.Equal(ok, true)
-// 	r.Equal(h != nil, true)
-// }
-
 func newWorkflowContextForTest(t *testing.T) wfContext.Context {
 	cm := corev1.ConfigMap{}
 	r := require.New(t)

diff --git a/pkg/providers/util/util_test.go b/pkg/providers/util/util_test.go
@@ -273,17 +273,6 @@ func TestLog(t *testing.T) {
 	}
 }
 
-// func TestInstall(t *testing.T) {
-// 	p := providers.NewProviders()
-// 	pCtx := process.NewContext(process.ContextData{})
-// 	pCtx.PushData(model.ContextStepName, "test-step")
-// 	Install(p, pCtx)
-// 	h, ok := p.GetHandler("util", "string")
-// 	r := require.New(t)
-// 	r.Equal(ok, true)
-// 	r.Equal(h != nil, true)
-// }
-
 func newWorkflowContextForTest(t *testing.T) wfContext.Context {
 	cm := corev1.ConfigMap{}
 	r := require.New(t)