Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit konflux pipeline #68

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

ernesgonzalez33
Copy link
Contributor

No description provided.

@ernesgonzalez33
Copy link
Contributor Author

PR to help pass EC checks. Don't merge before #67

@ernesgonzalez33 ernesgonzalez33 force-pushed the edit-konflux-pipeline branch 2 times, most recently from fec46b6 to 7545869 Compare September 13, 2024 09:49
@ernesgonzalez33
Copy link
Contributor Author

/retest

1 similar comment
@ernesgonzalez33
Copy link
Contributor Author

/retest

Signed-off-by: Ernesto González <[email protected]>
@ernesgonzalez33 ernesgonzalez33 marked this pull request as ready for review September 19, 2024 10:54
@ernesgonzalez33
Copy link
Contributor Author

/retest

1 similar comment
@ernesgonzalez33
Copy link
Contributor Author

/retest

@ernesgonzalez33
Copy link
Contributor Author

@yaacov @mnecas I know that the test is failing, but this is due to an architectural decision on Konflux to test components inside an app together. So it is testing this specific PR at the same time as the main branch of the console-plugin repo (which was failing), so until we don't merge these two working, it will keep failing. So my suggestion is to merge this PR and then test it with the #69

@yaacov
Copy link
Member

yaacov commented Sep 19, 2024

/retest

1 similar comment
@ernesgonzalez33
Copy link
Contributor Author

/retest

@yaacov yaacov merged commit 0a76bd8 into kubev2v:main Sep 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants