Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support deny action in bindings #14

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

f1ames
Copy link
Contributor

@f1ames f1ames commented Oct 31, 2023

This PR adds support for Deny action in policy bindings. It partially solves #10. It is based on and targets f1ames/feat/cloud-integration branch and should be merged after it.

Now, for Warn action, the list of violations is send as warnings. For Deny it is same but send as regular output, additionally resource is blocked and so it is interpreted as error by client (e.g. kubectl).

As stated in VAP docs (which we try to align) with:

Deny and Warn may not be used together since this combination needlessly duplicates the validation failure both in the API response body and the HTTP warning headers.

Changes

  • As above.

Fixes

  • None.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@f1ames f1ames marked this pull request as ready for review October 31, 2023 13:50
Copy link
Contributor

@murarustefaan murarustefaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Base automatically changed from f1ames/feat/cloud-integration to main November 2, 2023 10:31
@f1ames f1ames merged commit 2d531de into main Nov 2, 2023
17 checks passed
@f1ames f1ames deleted the f1ames/feat/deny-action branch November 2, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants