Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Volume Snapshot Classes Page #49381

Merged

Conversation

network-charles
Copy link
Contributor

Description

This improves the understanding of what happens when you run multiple CSI drivers and create a default VolumeSnapshotClass. For example:

  • The effect of creating a volume snapshot for multiple CSI drivers without specifying a VolumeSnapshotClass.
  • The effect of creating multiple default VolumeSnapshotClass for the same CSI driver.

Issue

Closes: #49069

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 9, 2025
@k8s-ci-robot k8s-ci-robot requested a review from thockin January 9, 2025 19:33
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 9, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 9, 2025
@network-charles network-charles force-pushed the network-charles-patch-4 branch from 25af537 to c0c4564 Compare January 9, 2025 19:40
Copy link

netlify bot commented Jan 9, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 25af537
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/678024800c25800008879a41
😎 Deploy Preview https://deploy-preview-49381--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 9, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c0c4564
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67802640e97a5b000881c91d
😎 Deploy Preview https://deploy-preview-49381--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Jan 9, 2025

Also relevant to #49362

@sftim
Copy link
Contributor

sftim commented Jan 9, 2025

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jan 9, 2025
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The page could use a bigger revision, but this is a nice improvement. Standalone, small, reviewable PRs like this are a good way to contribute.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d27c95080f1fb8859fdca638ada5d49cd9a869f2

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit d723e0b into kubernetes:main Jan 9, 2025
6 checks passed
@network-charles network-charles deleted the network-charles-patch-4 branch January 9, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement for k8s.io/docs/concepts/storage/volume-snapshot-classes/
3 participants