-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix netperf docker image build failure #2227
Conversation
- debian:jessie container is ~2 years old: apt repo keys are expired and prevent dependency installation - netperf needs -fcommon flag for building on newer compilers; see HewlettPackard/netperf#46 relevance: the default image (sirot/netperf-latest) used by the netperf test crashes when given the -testFrom and -testTo parameters. these parameters cannot be turned off, but are implicitly set when omitted by user. building a new container image is neccessary to run tests at all
|
Welcome @bitmeal! |
Hi @bitmeal. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Could you take a look at it Dorde? |
Thanks @bitmeal. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bitmeal, dlapcevic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
What
debian:jessie
todebian:bullseye
CFLAGS=-fcommon
to build of netperf binaryWhy
sirot/netperf-latest
used by the netperf test crashes when given the-testFrom
and-testTo
parameters. These parameters cannot be turned off, but are implicitly set when omitted by user; introduced by Add qperf support to netperf for network benchmarking #2144.debian:jessie
container on docker hub is ~2 years old: apt repo keys are expired, thus preventing dependency installation and container builddebian:bullseye
, with a newer compiler, netperf needs-fcommon
flag for building (as workaround); see nettest_omni: Remove duplicate variable definitions HewlettPackard/netperf#46Relevance/Value
Updating the container is necessary to run the tests at all, fixing a regression introduced by the additionally passed parameters from #2144
Which issue(s) this PR fixes:
Special notes for your reviewer:
What type of PR is this?
/kind bug
/kind regression