Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore exec subresource in APIResponsivenessPrometheus #1809

Merged
merged 1 commit into from
May 20, 2021
Merged

Ignore exec subresource in APIResponsivenessPrometheus #1809

merged 1 commit into from
May 20, 2021

Conversation

jupblb
Copy link
Contributor

@jupblb jupblb commented May 20, 2021 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
See this comment: #1096 (comment)

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:
See issue: #1096
See PR: kubernetes/test-infra#21694

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@jupblb
Ignore exec subresource in APIResponsivenessPrometheus
231e531 
Failures are understandable as exec commands can last more than 1s, therefore
they should be excluded from the API responsiveness measurement SLO so we can
unblock the API availability measurement.
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @jupblb. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 20, 2021
@k8s-ci-robot k8s-ci-robot requested review from mborsz and oxddr May 20, 2021 15:45
@jupblb jupblb mentioned this pull request May 20, 2021
Merged
@jupblb
Copy link
Contributor Author

jupblb commented May 20, 2021

/assign marseel
/assign tosi3k

@tosi3k
Copy link
Member

tosi3k commented May 20, 2021

Please replace the What this PR does / why we need it: part of the PR's description with a pointer to #1096 (comment).

Other than that LGTM.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2021
@tosi3k
Copy link
Member

tosi3k commented May 20, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2021
@tosi3k
Copy link
Member

tosi3k commented May 20, 2021

/assign @mborsz

@wojtek-t
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jupblb, tosi3k, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit b919e0e into kubernetes:master May 20, 2021
@jupblb jupblb deleted the api-availability branch May 20, 2021 21:52
@jupblb jupblb mentioned this pull request May 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marseel marseel marseel left review comments

@mborsz mborsz mborsz left review comments

@oxddr oxddr Awaiting requested review from oxddr

Assignees

@marseel marseel

@mborsz mborsz

@tosi3k tosi3k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jupblb @k8s-ci-robot @tosi3k @wojtek-t @marseel @mborsz