chore: refactor custom plugin monitor method #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
googs1025
commented
Dec 26, 2024
googs1025
commented
- refactor custom plugin monitor method
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
googs1025
commented
Dec 26, 2024
| @@ -296,18 +296,22 @@ func toConditionStatus(s cpmtypes.Status) types.ConditionStatus { | |||
| } | |||
| } | |||
|
|
|||
| // initializeStatus initializes the internal condition and also reports it to the node problem detector. | |||
| func (c *customPluginMonitor) initializeStatus() { | |||
There was a problem hiding this comment.
initializeStatus naming seems confusing, and the initialConditions does not need to be repeated
googs1025
force-pushed
the
refactor/custom_plugin
branch
from
74dbcfe to
32f8a10
Compare
googs1025
force-pushed
the
refactor/custom_plugin
branch
from
32f8a10 to
cf0870f
Compare
|
friendly ping @andyxning |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyxning, googs1025 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.