Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: fix missing kicbase in release #20291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

release: fix missing kicbase in release #20291

wants to merge 1 commit into from

Conversation

ComradeProgrammer
Copy link
Member

fix: fix missing kicbase in release

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ComradeProgrammer
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 19, 2025
@medyagh medyagh changed the title fix: fix missing kicbase in release release: fix missing kicbase in release Jan 22, 2025
medyagh
medyagh requested changes Jan 22, 2025
View reviewed changes
hack/jenkins/release_build_and_upload.sh
# upload to google bucket
gsutil -m cp out/* "gs://$BUCKET/releases/$TAGNAME/"

# Update "latest" release for non-beta/non-alpha builds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ComradeProgrammer is this releated to this PR or is this something generally fixing ? what is exactly doing?

hack/jenkins/release_build_and_upload.sh
@@ -136,5 +127,19 @@ do
docker rmi -f ${IMAGE_NAME}
done


# upload to google bucket
gsutil -m cp out/* "gs://$BUCKET/releases/$TAGNAME/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there might be things in out folder that we dont want ? maybe like Linters binaries or somethign like that ? and why this is added to this PR? before this PR we didnt have artifacts in the GCS bucket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh requested changes

@prezha prezha Awaiting requested review from prezha

@spowelljr spowelljr Awaiting requested review from spowelljr

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ComradeProgrammer @k8s-ci-robot @medyagh