-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create first HNS network before Flannel #38
Conversation
@benmoss: GitHub didn't allow me to assign the following users: gab-satchi. Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benmoss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Also add back a route for 169.254.169.254, a commonly used metadata server IP. HNS network initialization breaks this on Windows.
@neolit123 can you lgtm this? Gab isn't a kubernetes-sigs member |
based on @gab-satchi 's review. @gab-satchi if you have enough PRs for the kubernetes or kubernetes-sigs orgs you should request membership. with k org you are eligible for the k-sigs org. |
@neolit123 coincidentally made the membership request today 👍 |
I applied flannel-host-gw.yml, and got an error:
I have posted a comment here. Today I found a mistake in the setup.go as the review I opened above, can anybody check this review? |
@xie-qianyue did you find a bug? Please open a new issue rather than commenting on closed ones. |
This is just basically this code, wrapped in a Go binary to make executing it through Wins easier. I tried initially to just run powershell directly with Wins, but it errored when Wins tried to rename
powershell.exe
.This also adds back a route for 169.254.169.254, a commonly used metadata server IP. HNS network initialization breaks this on Windows.
Fixes #37
Fixes #36
/assign @gab-satchi