Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create first HNS network before Flannel #38

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

benmoss
Copy link
Contributor

@benmoss benmoss commented Mar 3, 2020

This is just basically this code, wrapped in a Go binary to make executing it through Wins easier. I tried initially to just run powershell directly with Wins, but it errored when Wins tried to rename powershell.exe.

This also adds back a route for 169.254.169.254, a commonly used metadata server IP. HNS network initialization breaks this on Windows.

Fixes #37
Fixes #36

/assign @gab-satchi

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 3, 2020
@k8s-ci-robot
Copy link
Contributor

@benmoss: GitHub didn't allow me to assign the following users: gab-satchi.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is just basically this code, wrapped in a Go binary to make executing it through Wins easier. I tried initially to just run powershell directly with Wins, but it errored when Wins tried to rename powershell.exe.

This also adds back a route for 169.254.169.254, a commonly used metadata server IP. HNS network initialization breaks this on Windows.

Fixes #37
Fixes #36

/assign @gab-satchi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmoss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 3, 2020
Also add back a route for 169.254.169.254, a commonly used metadata
server IP. HNS network initialization breaks this on Windows.
@benmoss
Copy link
Contributor Author

benmoss commented Mar 6, 2020

@neolit123 can you lgtm this? Gab isn't a kubernetes-sigs member

@neolit123
Copy link
Member

based on @gab-satchi 's review.
/lgtm

@gab-satchi if you have enough PRs for the kubernetes or kubernetes-sigs orgs you should request membership. with k org you are eligible for the k-sigs org.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0c91a7a into kubernetes-sigs:master Mar 6, 2020
@gab-satchi
Copy link
Member

@neolit123 coincidentally made the membership request today 👍

@xie-qianyue
Copy link

I applied flannel-host-gw.yml, and got an error:

E0507 20:10:43.865945    8896 reflector.go:201] github.com/coreos/flannel/subnet/kube/kube.go:307: Failed to list *v1.Node: Get https://10.246.44.131:6443/api/v1/nodes?resourceVersion=0: http2: no cached connection was available

I have posted a comment here.

Today I found a mistake in the setup.go as the review I opened above, can anybody check this review?

@benmoss
Copy link
Contributor Author

benmoss commented May 8, 2020

@xie-qianyue did you find a bug? Please open a new issue rather than commenting on closed ones.

@xie-qianyue
Copy link

@benmoss OK, I open a new issue: #83.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
5 participants