Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake: fix qos sort plugin flaky integration test #861

Merged
merged 1 commit into from
Jan 15, 2025
Merged

flake: fix qos sort plugin flaky integration test #861

merged 1 commit into from
Jan 15, 2025

Conversation

googs1025
Copy link
Member

What type of PR is this?

/kind flake

What this PR does / why we need it:

  • During local testing, I found that the integration test was unstable. I guess that the creation and entry into the scheduling queue are not simultaneous, this causes unstable results.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 14, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 14, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 14, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name Link
🔨 Latest commit 1a27c63
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/67875534af17c100086b6f3e

@googs1025
Copy link
Member Author

/test pull-scheduler-plugins-integration-test-master

2 similar comments
@googs1025
Copy link
Member Author

/test pull-scheduler-plugins-integration-test-master

@googs1025
Copy link
Member Author

/test pull-scheduler-plugins-integration-test-master

@googs1025
Copy link
Member Author

https://prow.k8s.io/pr-history/?org=kubernetes-sigs&repo=scheduler-plugins&pr=862
test from pr #862. There will be unstable flakes

@googs1025 googs1025 marked this pull request as ready for review January 15, 2025 01:05
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2025
@googs1025 googs1025 marked this pull request as draft January 15, 2025 01:12
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2025
@googs1025
Copy link
Member Author

/test pull-scheduler-plugins-integration-test-master

@googs1025 googs1025 marked this pull request as ready for review January 15, 2025 06:55
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2025
googs1025
googs1025 commented Jan 15, 2025
View reviewed changes
test/integration/qos_test.go
v1.ResourceMemory: *resource.NewQuantity(200, resource.DecimalSI),
},
}
// Make pods[2] Guaranteed.
pods[2].Spec.Containers[0].Resources = v1.ResourceRequirements{
Requests: v1.ResourceList{
v1.ResourceCPU: *resource.NewMilliQuantity(100, resource.DecimalSI),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some investigation, I found that the problem should be here: Guaranteed pod definition needs to be specified both cpu mem limit and request.
FYI: https://kubernetes.io/docs/concepts/workloads/pods/pod-qos/#criteria

@googs1025
Copy link
Member Author

@Huang-Wei friendly ping :)

@googs1025 googs1025 changed the title flake: fix qos sort plugin flaky test flake: fix qos sort plugin flaky integration test Jan 15, 2025
Huang-Wei
Huang-Wei reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: googs1025, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2025
@Huang-Wei Huang-Wei mentioned this pull request Jan 15, 2025
Merged
@k8s-ci-robot k8s-ci-robot merged commit 8f6ba42 into kubernetes-sigs:master Jan 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Huang-Wei left review comments

@Tal-or Tal-or Awaiting requested review from Tal-or

@zwpaper zwpaper Awaiting requested review from zwpaper

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@Huang-Wei Huang-Wei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@googs1025 @k8s-ci-robot @Huang-Wei