Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(QOSSort): refine queue sorting logic by adding inqueue timestamp #855

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

googs1025
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Jan 13, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2025
Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name Link
🔨 Latest commit 3b77d02
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/6785b671c839d70008dd65c5

@googs1025 googs1025 marked this pull request as draft January 13, 2025 12:38
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2025
@googs1025 googs1025 force-pushed the qos_sort branch 2 times, most recently from fbaecca to 0b6eee1 Compare January 13, 2025 12:50
@googs1025 googs1025 marked this pull request as ready for review January 13, 2025 12:50
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2025
@googs1025
Copy link
Member Author

friendly ping @Huang-Wei

@googs1025 googs1025 force-pushed the qos_sort branch 5 times, most recently from b6e4c8a to ab70fd5 Compare January 13, 2025 14:55
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 13, 2025
t.Fatalf("Failed to create Pod %q: %v", pods[i].Name, err)
}
// Concurrently create all Pods.
var wg sync.WaitGroup
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some unstable flakes here, I still need to think about how to deal with it. 🤔

@googs1025
Copy link
Member Author

/test pull-scheduler-plugins-integration-test-master

@Huang-Wei
Copy link
Contributor

@googs1025 this plugin was created just for demonstration purpose, and not enabled by default (if not in any case):

// Sample plugins below.
// app.WithPlugin(crossnodepreemption.Name, crossnodepreemption.New),
app.WithPlugin(podstate.Name, podstate.New),
app.WithPlugin(qos.Name, qos.New),

So it's not required to "sync" with the upstream plugin.

@googs1025
Copy link
Member Author

@googs1025 this plugin was created just for demonstration purpose, and not enabled by default (if not in any case):

// Sample plugins below.
// app.WithPlugin(crossnodepreemption.Name, crossnodepreemption.New),
app.WithPlugin(podstate.Name, podstate.New),
app.WithPlugin(qos.Name, qos.New),

So it's not required to "sync" with the upstream plugin.

This pr is not to sync k/k upstream code. We are currently using the qos plugin internally. When we used it, we found that the sorting seemed to be a bit missing. The original logic only considered priority and qos type. IIUC, this is not to sync with the upstream, but to complete the missing part.

@Huang-Wei
Copy link
Contributor

We are currently using the qos plugin internally. When we used it, we found that the sorting seemed to be a bit missing.

ok, good to know that.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: googs1025, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit fd19685 into kubernetes-sigs:master Jan 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants