-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(QOSSort): refine queue sorting logic by adding inqueue timestamp #855
Conversation
✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.
|
fbaecca
to
0b6eee1
Compare
friendly ping @Huang-Wei |
b6e4c8a
to
ab70fd5
Compare
t.Fatalf("Failed to create Pod %q: %v", pods[i].Name, err) | ||
} | ||
// Concurrently create all Pods. | ||
var wg sync.WaitGroup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be some unstable flakes here, I still need to think about how to deal with it. 🤔
/test pull-scheduler-plugins-integration-test-master |
@googs1025 this plugin was created just for demonstration purpose, and not enabled by default (if not in any case): scheduler-plugins/cmd/scheduler/main.go Lines 63 to 66 in 1e1b6b0
So it's not required to "sync" with the upstream plugin. |
This pr is not to sync k/k upstream code. We are currently using the qos plugin internally. When we used it, we found that the sorting seemed to be a bit missing. The original logic only considered priority and qos type. IIUC, this is not to sync with the upstream, but to complete the missing part. |
ok, good to know that. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: googs1025, Huang-Wei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
https://github.com/kubernetes/kubernetes/blob/35d6959ace07a4edc2a17da3bd4d0fcd625caa83/pkg/scheduler/framework/plugins/queuesort/priority_sort.go#L40-L49
Which issue(s) this PR fixes:
Fixes #None
Special notes for your reviewer:
Does this PR introduce a user-facing change?