Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controllers: fix ServiceReconciler headless service reconciliation #98

Merged
merged 1 commit into from
Jan 16, 2025
Merged

controllers: fix ServiceReconciler headless service reconciliation #98

merged 1 commit into from
Jan 16, 2025

Conversation

MrFreezeex
Copy link
Member

Headless services should have an empty list of IPs instead of a list containing the "None" string.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2025
@MrFreezeex MrFreezeex mentioned this pull request Jan 10, 2025
Merged
@tpantelis
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 10, 2025
@MrFreezeex
controllers: fix ServiceReconciler headless service reconciliation
8e35cab 
Headless services should have an empty list of IPs instead of a list
containing the "None" string.

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
@MrFreezeex MrFreezeex force-pushed the fix-controller-service branch from ebc5151 to 8e35cab Compare January 16, 2025 14:49
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2025
@MrFreezeex
Copy link
Member Author

MrFreezeex commented Jan 16, 2025 •
edited
Loading

This should be good too, I rebased it after #80 merge. When you have a moment to also review this @skitt @tpantelis that would be awesome 🙏 (and thanks for all the other PRs that you already reviewed btw ❤️).

FYI I would like to bump mcs-api in our coming days as a "last minute fix" to make it in time for backporting it to Cilium next stable release 🙏. There is still like probably a full week for that, so I don't need it absolutely now there is still a bit of time but it's still is coming relatively fast 😅 !

@skitt
Copy link
Member

skitt commented Jan 16, 2025

Oh wow, yes, “None” is rather unfortunate… I’m restoring Tom’s LGTM based on his previous vote.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit 62ede9a into kubernetes-sigs:master Jan 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremyOT JeremyOT Awaiting requested review from JeremyOT

@lauralorenz lauralorenz Awaiting requested review from lauralorenz

Assignees

@skitt skitt

@tpantelis tpantelis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrFreezeex @tpantelis @skitt @k8s-ci-robot