Update Demo Scripts (make demo) for Apple Silicon (M4) Compatibility and Python 3 #94
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Welcome @kahirokunn! |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @kahirokunn. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/L
kahirokunn
changed the title
make demo Script for M4 MacBook Compatibility
There was a problem hiding this comment.
Hi! Welcome and thanks for the contribution! I left a couple of comments, most of them are style/nits except the one about downloading the coredns binary instead of building it which I am concerned about but apart from that this looks great thanks again!
/ok-to-test
k8s-ci-robot
added
ok-to-test
kahirokunn
force-pushed
the
make-demo-multi-arch
branch
from
4ed8934 to
977e345
Compare
k8s-ci-robot
added
size/M
kahirokunn
force-pushed
the
make-demo-multi-arch
branch
4 times, most recently
from
e2920a9 to
360da88
Compare
k8s-ci-robot
added
size/L
|
/retest-required |
|
I am currently re-testing the functionality. I will provide an update once it is completed. |
kahirokunn
force-pushed
the
make-demo-multi-arch
branch
from
b6d9ddc to
f7f55b1
Compare
|
I've tested this and confirmed it works once this PR is merged.
|
- Resolve absolute script paths to ensure consistency. - Introduce platform detection for multi-arch coredns binary download. - Replace tar download with git clone for coredns due to 'make' dependency. Signed-off-by: kahirokunn <[email protected]>
Signed-off-by: kahirokunn <[email protected]>
Co-authored-by: Arthur Outhenin-Chalandre <[email protected]>
kahirokunn
force-pushed
the
make-demo-multi-arch
branch
2 times, most recently
from
db6d9d1 to
79b4cf3
Compare
|
Testing has been completed successfully. 👍 |
|
@MrFreezeex I think I'm falling down with an error in an unrelated area, what do you think I should do? |
- Switch to using a Docker container for consistent coreDNS build across platforms. - Avoid manual architecture detection and platform-specific binary handling. Signed-off-by: kahirokunn <[email protected]>
kahirokunn
force-pushed
the
make-demo-multi-arch
branch
from
79b4cf3 to
d439c09
Compare
|
It's all been passed! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kahirokunn, MrFreezeex The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Also, could you rebase your commits to avoid having separate “Apply suggestions from review” commits? |
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
lgtm
- Switch to using `realpath` for resolving script paths - Use more concise variable definitions for paths
kahirokunn
force-pushed
the
make-demo-multi-arch
branch
from
7def7f2 to
120ae9d
Compare
|
@skitt |
This pull request updates the “make demo” workflow to ensure that it runs properly on Apple Silicon (M4) machines.
• Switched from Python to Python 3 in the demo script (edit-meta).
• Used absolute paths to address environment-related issues in demo.sh.
• Added architecture detection in scripts/up.sh for a multi-arch CoreDNS build.
• Replaced the tar-based CoreDNS download with an equivalent git clone step to support “make” on M4.
All of these modifications aim to maintain backward compatibility while extending usability to Apple Silicon (M4) hardware. Testing locally shows that “make demo” now works as expected on M4 MacBooks. Please review and let me know if further changes are required. Thank you!