Merge pull request #80 from MrFreezeex/svcoperator-multipleips

apis: increase max lengths of ips to 2
kubernetes-sigs · Jan 16, 2025 · e786573 · e786573
2 parents b858d70 + f9bf777
commit e786573
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/config/crd/multicluster.x-k8s.io_serviceimports.yaml b/config/crd/multicluster.x-k8s.io_serviceimports.yaml
@@ -74,7 +74,7 @@ spec:
                 ips:
                   description: ip will be used as the VIP for this service when type is ClusterSetIP.
                   type: array
-                  maxItems: 1
+                  maxItems: 2
                   items:
                     type: string
                 ports:

diff --git a/pkg/apis/v1alpha1/serviceimport.go b/pkg/apis/v1alpha1/serviceimport.go
@@ -53,7 +53,7 @@ type ServiceImportSpec struct {
 	// +listType=atomic
 	Ports []ServicePort `json:"ports"`
 	// ip will be used as the VIP for this service when type is ClusterSetIP.
-	// +kubebuilder:validation:MaxItems:=1
+	// +kubebuilder:validation:MaxItems:=2
 	// +optional
 	IPs []string `json:"ips,omitempty"`
 	// type defines the type of this service.

diff --git a/pkg/controllers/service.go b/pkg/controllers/service.go
@@ -68,7 +68,8 @@ func (r *ServiceReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
 		return ctrl.Result{}, nil
 	}
 
-	svcImport.Spec.IPs = []string{service.Spec.ClusterIP}
+	ipsLen := min(2, len(service.Spec.ClusterIPs))
+	svcImport.Spec.IPs = service.Spec.ClusterIPs[:ipsLen]
 	if err := r.Client.Update(ctx, &svcImport); err != nil {
 		return ctrl.Result{}, err
 	}