Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Rocky Linux 9 building on Proxmox #1593

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

manetherenio
Copy link

Change description

This does a handful of things to get Rocky Linux 9 building under Proxmox.

First, in the Ansible playbook, I restrict networkd-dispatcher to Ubuntu since it doesn't appear to exist as a package under RHEL9/Rocky 9.

Next, Goss was looking for cloud-utils as an installed package, but the correct package is cloud-utils-growpart. In addition to that, Goss was verifying open-vm-tools was installed, but that's a hypervisor integration for vSphere, not QEMU/Proxmox. So I replaced that with qemu-guest-agent.

After that, I switched the disk format to raw. QCOW2 isn't supported on ZFS, and the Packer default is raw anyway:

https://developer.hashicorp.com/packer/integrations/hashicorp/proxmox/latest/components/builder/iso#disks

Raw will work on all filesystems supported by Proxmox, so it's a safe default.

I also switched the disk interface to virtio. With the scsi interface, Rocky wasn't detecting any disks. I can switch this to sata if needed, but both Ubuntu 24.04 and 22.04 built fine with virtio and IIRC, it should get slightly better performance than the scsi interface.

Finally, I set the CPU type to Westmere because RHEL9 (and thus Rocky) requires a minimum of x86-64-v2 to boot. Intel Westmere is the oldest microarchitecture that qualifies for this distinction. The default CPU type (kvm64) gives a kernel panic on installer startup without this. Please note that the genericized CPU type (x86-64-v2-AES) requires Proxmox 8.0+, so setting this to Westmere allows older versions of Proxmox to use the image-builder.

https://pve.proxmox.com/wiki/Roadmap#Proxmox_VE_8.0

I've personally tested this against my Proxmox server running the latest (8.2.2) and have built images for Rocky Linux 9, Ubuntu 22.04, and Ubuntu 24.04, so it should be regression free.

Related issues

  • Fixes #

Additional context

Copy link

linux-foundation-easycla bot commented Oct 13, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign drew-viles for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 13, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @manetherenio!

It looks like this is your first PR to kubernetes-sigs/image-builder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/image-builder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @manetherenio. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 13, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 13, 2024
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 15, 2024
@k8s-ci-robot
Copy link
Contributor

@manetherenio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
json-sort-check 9b820ef link true /test json-sort-check

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants