WIP: chore: changes for building CAPA amis

[richardcase]

Change description

Related issues

• Fixes #

Additional context

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jsturtevant for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[holmanb]

@richardcase per your comment:

We're running into an error when the boothook script runs in the local stage as the network and AWS creds are not setup yet and so the AWS cli calls fail. However, with this CAPA branch there is still a reboot and so when the machine comes up the second time the boothook script runs (as the network and creds are setup) and we get k8s coming up.

I think we can resolve this by not attempting to get data during the network stage. To accomplish this, we can apply the following change, which will override the local datasource to do nothing and return false when DataSourceEc2KubernetesLocal._get_data() is called, so that during network stage cloud-init will try to get data using the DataSourceEc2Kubernetes class. This should force the boothook to run during the network stage, at which point the AWS creds should presumably be setup (although I'm now sure what is responsible for that).

diff --git a/cloudinit/sources/DataSourceEc2Kubernetes.py b/cloudinit/sources/DataSourceEc2Kubernetes.py
index 50f51faf0..115bba3b6 100644
--- a/cloudinit/sources/DataSourceEc2Kubernetes.py
+++ b/cloudinit/sources/DataSourceEc2Kubernetes.py
@@ -89,7 +89,8 @@ class DataSourceEc2Kubernetes(DataSourceEc2.DataSourceEc2):
 
 
 class DataSourceEc2KubernetesLocal(DataSourceEc2Kubernetes):
-    perform_dhcp_setup = True  # Use dhcp before querying metadata
+    def _get_data(self):
+        return False
 
 
 # Used to match classes to dependencies

[Nalum]

@holmanb does DataSourceEc2KubernetesLocal need to extend DataSourceEc2Kubernetes? We were discussing this and thought we might be able to do DataSourceEc2KubernetesLocal(DataSourceEc2.DataSourceEc2), but overriding _get_data works too.

[holmanb]

@holmanb does DataSourceEc2KubernetesLocal need to extend DataSourceEc2Kubernetes?

Not necessarily. There are a few different ways to accomplish the same thing.

We were discussing this and thought we might be able to do DataSourceEc2KubernetesLocal(DataSourceEc2.DataSourceEc2), but overriding _get_data works too.

It really doesn't matter which you inherit from for this local datasource. Either way you still need to override _get_data to do nothing and return false. If you just inherit from DataSourceEc2.DataSourceEc2, then I would expect that getting the user-data (the MIME containing the boothook and include-url) will succeed in the local stage and it won't try again in network stage, so it wouldn't behave any differently than the current Ec2 datasource does.