chore: update README.md for DeschedulerPolicy #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
googs1025
commented
Dec 18, 2024
| @@ -43,7 +43,7 @@ type DeschedulerPolicy struct { | |||
|
|
|||
| // EvictionFailureEventNotification should be set to true to enable eviction failure event notification. | |||
| // Default is false. | |||
| EvictionFailureEventNotification *bool | |||
| EvictionFailureEventNotification *bool `json:"evictionFailureEventNotification,omitempty"` | |||
|
/kind cleanup |
k8s-ci-robot
added
the
kind/cleanup
a7i
reviewed
Dec 23, 2024
README.md
Outdated
| | `metricsCollector.enabled` |`bool`| `false` | enables kubernetes [metrics server](https://kubernetes-sigs.github.io/metrics-server/) collection | | ||
| | Name | Type | Default Value | Description | | ||
| |------------------------------------|--------|---------------|----------------------------------------------------------------------------------------------------------------------------| | ||
| | `nodeSelector` | string | nil | Limiting the nodes which are processed. Only used when `nodeFit`=`true` and only by the PreEvictionFilter Extension Point. | |
There was a problem hiding this comment.
any particular reason why string and nil no longer have a backtick? it's inconsistent with other sections
googs1025
force-pushed
the
readme/update
branch
from
4d479f5 to
274ef45
Compare
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
/test pull-descheduler-verify-master |
googs1025
force-pushed
the
readme/update
branch
from
274ef45 to
ad6f108
Compare
k8s-ci-robot
removed
the
lgtm
googs1025
force-pushed
the
readme/update
branch
from
ad6f108 to
03246d6
Compare
googs1025
commented
Jan 6, 2025
| @@ -2,7 +2,7 @@ | |||
| // +build !ignore_autogenerated | |||
|
|
|||
| /* | |||
| Copyright 2024 The Kubernetes Authors. | |||
| Copyright 2025 The Kubernetes Authors. | |||
There was a problem hiding this comment.
Use update to update the generated files
➜ descheduler git:(readme/update) ./hack/update-generated-deep-copies.sh
➜ descheduler git:(readme/update) ✗ ./hack/update-generated-defaulters.sh
➜ descheduler git:(readme/update) ./hack/update-generated-conversions.sh
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update README.md for DeschedulerPolicy