-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS-3841: Add custom Endpoints to CAPG #1409
base: main
Are you sure you want to change the base?
Conversation
** Update the api and configs
…hey are supplied via the Cluster Spec.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: barbacbd The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @barbacbd. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks @barbacbd /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM (pending CI checks). Can you also add this to the book https://cluster-api-gcp.sigs.k8s.io/? Source files can be found here https://github.com/kubernetes-sigs/cluster-api-provider-gcp/tree/main/docs/book
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @barbacbd for contributing this, reads well and makes sense.
/lgtm
@salasberryfin I don't see any docs on similar fields in the book, or am I missing something? |
/assign @cpanato @richardcase |
Yes @damdo, you're right. Maybe we can create a separate issue to improve docs on relevant fields in the spec, like what's added here. The book is still lacking lot's of information. |
I agree, we probably should, thanks for bringing that up @salasberryfin let's track this separately 👍 |
What type of PR is this?
/kind api-change
/kind feature
What this PR does / why we need it:
via the Cluster Spec
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes # #1391
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: