Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies ahead of new external-provisioner release #1325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AndrewSirenko
Copy link
Contributor

@AndrewSirenko AndrewSirenko commented Jan 8, 2025

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Upgrade dependencies ahead of new external-provisioner release. Will fail for now until new sig-storage-lib-external-provisioner patch release. See special notes section.

  1. Note that new version of csi-translation-lib supports contextual logging, but provisioner does not. Therefore I passed down a klog.TODO() for now to unblock dep bump.

  2. Had to regenerate ProvisionerCSITranslator mock because of ^^. Used mockgen -package controller -destination=./pkg/controller/fake_translator_test.go -source=./pkg/controller/controller.go ProvisionerCSITranslator

  3. Might have to have replace directive for errdefs until github.com/google/cadvisor upgrades to errdefs v1.0.0. Will try to see if Go complains if we import both v0.1.0 and v1.0.0 once the lib gets a new patch version.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Passes make; make test locally if I include replace directive replace sigs.k8s.io/sig-storage-lib-external-provisioner/v11 => ../sig-storage-lib-external-provisioner to incorporate kubernetes-sigs/sig-storage-lib-external-provisioner#182

It will fail CI for now.

/hold

Holding until https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/pull/182s merged

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrewSirenko
Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 8, 2025
@anchaube
Copy link

anchaube commented Jan 9, 2025

Hello Team
We are waiting on the release of the following changes as it has blocked us from updating to k8s v1.32.

@AndrewSirenko
Copy link
Contributor Author

@anchaube FYI this PR is blocked until new release of https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner

@AndrewSirenko
Copy link
Contributor Author

/retest

@AndrewSirenko
Copy link
Contributor Author

Forgot to update vendor dir now that new sig-storage-lib-external-provisioner released... One moment

@AndrewSirenko
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants