-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies ahead of new external-provisioner release #1325
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrewSirenko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hello Team |
@anchaube FYI this PR is blocked until new release of https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner |
/retest |
Forgot to update vendor dir now that new sig-storage-lib-external-provisioner released... One moment |
ec8c131
to
8ea8784
Compare
/unhold |
What type of PR is this?
What this PR does / why we need it:
Upgrade dependencies ahead of new external-provisioner release. Will fail for now until new sig-storage-lib-external-provisioner patch release. See special notes section.
Note that new version of csi-translation-lib supports contextual logging, but provisioner does not. Therefore I passed down a
klog.TODO()
for now to unblock dep bump.Had to regenerate ProvisionerCSITranslator mock because of ^^. Used
mockgen -package controller -destination=./pkg/controller/fake_translator_test.go -source=./pkg/controller/controller.go ProvisionerCSITranslator
Might have to have replace directive for errdefs until
github.com/google/cadvisor
upgrades to errdefs v1.0.0. Will try to see if Go complains if we import both v0.1.0 and v1.0.0 once the lib gets a new patch version.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Passes
make; make test
locally if I include replace directivereplace sigs.k8s.io/sig-storage-lib-external-provisioner/v11 => ../sig-storage-lib-external-provisioner
to incorporate kubernetes-sigs/sig-storage-lib-external-provisioner#182It will fail CI for now.
/hold
Holding until https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/pull/182s merged
Does this PR introduce a user-facing change?: