Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[USERGUIDE] LLM Hyperparameter Optimization API #3952
base: master
Are you sure you want to change the base?
[USERGUIDE] LLM Hyperparameter Optimization API #3952
Changes from all commits
181719d
aa3b2be
36f2c1e
b7120e0
182b493
21646a8
cc71dee
56e4e53
6f36f1e
41efc88
856f822
9e79820
db9cabf
0b9d9bd
6996c45
87e0a1b
e1b7b35
4addd74
d0d3c92
2eda5a5
d308043
f416581
4a17838
7298213
372cce4
a582176
90df939
46f6e7c
47a50b2
7e4520f
29e789e
7214905
05bf688
68aa6b8
a5b8473
27f8189
b72a723
47659c5
85f2283
6a2e59a
ef11299
37fbca2
e4e190c
c59f268
0447f73
94240ac
23904d9
e0ef337
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to discussion here, can you move "Training Operator control plane" in front of "Katib control plane"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And it would be better to add a small note about it in this section :) For example:
Note: Please ensure that the Training Operator control plane is installed before the Katib control plane. This ensures the correct namespace labels are applied and enables the PyTorchJob CRD for use in Katib.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested this code example? Does it work well? If not, I can run this example locally when I have time and let you know if I encounter any issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have created an issue for myself to add a notebook for it, i'll try to do it myself (for learning purpose) and will contact you with issue i may encounter. would it be possible for me to message you on slack?
related issue: kubeflow/katib#2480
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Sure, feel free to contact me or ask in this slack channel if you meet any problem.