-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce cache_key for cache key customization #11434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @zzmao ! This is spawning from https://docs.google.com/document/d/1oNgYyFYondaVSFf9Pd3Q9uVzaqBr5wrOMHKgX9MMa78/edit?tab=t.0 right? @zzmao can we get an associated github issue for this and mention both the doc and the issue in the PR body for tracking purposes? is there a backend follow up planned for this pr? You'll also need to sign off on your commits to pass the dco check |
Signed-off-by: Ze Mao <[email protected]>
Hi @HumairAK , Thanks for the review. Addressed your comment. Backend change is TBD. Open for community contribution. |
/lgtm |
Signed-off-by: Ze Mao <[email protected]>
Signed-off-by: Ze Mao <[email protected]> Co-authored-by: Ze Mao <[email protected]>
Description of your changes:
Introduce cache_key for cache key customizaation for issue #11328
Doc: https://docs.google.com/document/d/1oNgYyFYondaVSFf9Pd3Q9uVzaqBr5wrOMHKgX9MMa78/edit?tab=t.0
Checklist: