Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce cache_key for cache key customization #11434

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

zzmao
Copy link
Collaborator

@zzmao zzmao commented Dec 3, 2024

Description of your changes:
Introduce cache_key for cache key customizaation for issue #11328
Doc: https://docs.google.com/document/d/1oNgYyFYondaVSFf9Pd3Q9uVzaqBr5wrOMHKgX9MMa78/edit?tab=t.0

Checklist:

@zzmao zzmao requested review from chensun and removed request for zijianjoy and connor-mccarthy December 3, 2024 23:54
@zzmao zzmao changed the title chore: Upgrade kfp-pipeline-spec version to 0.6.0 chore: Introduce cache_key for cache key customization Dec 4, 2024
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK
Copy link
Collaborator

HumairAK commented Dec 4, 2024

Thanks @zzmao !

This is spawning from https://docs.google.com/document/d/1oNgYyFYondaVSFf9Pd3Q9uVzaqBr5wrOMHKgX9MMa78/edit?tab=t.0 right? @zzmao can we get an associated github issue for this and mention both the doc and the issue in the PR body for tracking purposes?

is there a backend follow up planned for this pr?

You'll also need to sign off on your commits to pass the dco check

@google-oss-prow google-oss-prow bot removed the lgtm label Dec 5, 2024
@zzmao zzmao changed the title chore: Introduce cache_key for cache key customization feat: Introduce cache_key for cache key customization Dec 5, 2024
@zzmao
Copy link
Collaborator Author

zzmao commented Dec 5, 2024

Hi @HumairAK ,

Thanks for the review. Addressed your comment.

Backend change is TBD. Open for community contribution.

@chensun
Copy link
Member

chensun commented Dec 5, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 5, 2024
@google-oss-prow google-oss-prow bot merged commit 50b367f into kubeflow:master Dec 5, 2024
12 checks passed
@hbelmiro
Copy link
Contributor

hbelmiro commented Dec 6, 2024

@zzmao can you please update the status of #11328 explaining that it's partially implemented by this PR?

zzmao pushed a commit to zzmao/pipelines that referenced this pull request Dec 6, 2024
google-oss-prow bot pushed a commit that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants