fix(ui): turn off GKE metadata by default

Since GKE is only one of many platforms, change the default value of `DISABLE_GKE_METADATA` to `true`. Edit the gcp manifest to override that to `false` on GCP. Fixes: #11247 Signed-off-by: Greg Sheremeta <[email protected]>
kubeflow · Oct 21, 2024 · fcd7a8f · fcd7a8f
1 parent c2a7713
commit fcd7a8f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/frontend/server/configs.ts b/frontend/server/configs.ts
@@ -101,7 +101,7 @@ export function loadConfigs(argv: string[], env: ProcessEnv): UIConfigs {
     /** The main container name of a pod where logs are retrieved */
     POD_LOG_CONTAINER_NAME = 'main',
     /** Disables GKE metadata endpoint. */
-    DISABLE_GKE_METADATA = 'false',
+    DISABLE_GKE_METADATA = 'true',
     /** Enable authorization checks for multi user mode. */
     ENABLE_AUTHZ = 'false',
     /** Deployment type. */

diff --git a/manifests/kustomize/env/gcp/gcp-configurations-patch.yaml b/manifests/kustomize/env/gcp/gcp-configurations-patch.yaml
@@ -20,3 +20,16 @@ spec:
                 configMapKeyRef:
                   name: pipeline-install-config
                   key: gcsProjectId
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: ml-pipeline-ui
+spec:
+  template:
+    spec:
+      containers:
+        - name: ml-pipeline-ui
+          env:
+            - name: DISABLE_GKE_METADATA
+              value: 'false'