Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ws): enhance e2e test setup and cleanup #39

Open
wants to merge 4 commits into
base: notebooks-v2
Choose a base branch
from

Conversation

Adembc
Copy link

@Adembc Adembc commented Sep 2, 2024

This PR introduces the following changes:

  • Removes the prompt for end-to-end (E2E) test execution.
  • Adds checks to verify if the CertManager and Prometheus operators are already installed. This prevents reinstallation and avoids unnecessary deletion.
  • Added support for skipping CertManager installation with the environment variable CERT_MANAGER_INSTALL_SKIP.
  • Added support for skipping Prometheus installation with the environment variable PROMETHEUS_INSTALL_SKIP.
  • Enhances the E2E test setup and cleanup.

These changes follow discussions with the Kubebuilder maintainer, who has already merged similar updates into Kubebuilder in this PR.

Note:

  • PROMETHEUS_INSTALL_SKIP is currently set to true by default because the Prometheus operator is not required at this time. However, it might be needed in the future, so the option remains configurable.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Adembc Adembc changed the title E2e tests enhancement test(ws): enhance e2e test setup and cleanup Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

2 participants