-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ws): enhance e2e test setup and cleanup #39
base: notebooks-v2
Are you sure you want to change the base?
Conversation
Signed-off-by: Adem Baccara <[email protected]>
Signed-off-by: Adem Baccara <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Adem Baccara <[email protected]>
Signed-off-by: Adem Baccara <[email protected]>
This PR introduces the following changes:
CERT_MANAGER_INSTALL_SKIP
.PROMETHEUS_INSTALL_SKIP
.These changes follow discussions with the Kubebuilder maintainer, who has already merged similar updates into Kubebuilder in this PR.
Note:
PROMETHEUS_INSTALL_SKIP
is currently set totrue
by default because the Prometheus operator is not required at this time. However, it might be needed in the future, so the option remains configurable.