Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ws): update Workspace and WorkspaceKind definitions #16

Merged

Conversation

thesuperzapper
Copy link
Member

This PR continues from #6.

It makes the following changes to align with the updates discussed, see thesuperzapper/kubeflow-notebooks-v2-design@ee651ee for the changes.

The key changes are:

  • Renaming some of the Go types because they were likely to overlap with future ones, e.g. PodVolumes became WorkspacePodVolumes.
  • Add spec for labels on each spawner option, to be used as filters the UI when selecting from options.
  • Add status for WorkspaceKind which lists the options and how many Workspaces are using them
  • Add redirect "message" to be displayed in the UI when warning users about the update.

I have also re-ordered the types and added section headings to make the go files easier to read.

@thesuperzapper
Copy link
Member Author

I cant assign @jiridanek as a reviewer because he is not a member yet, but please take a look.

@jiridanek
Copy link
Member

look taken

/lgtm

Copy link

@jiridanek: changing LGTM is restricted to collaborators

In response to this:

look taken

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ederign
Copy link
Member

ederign commented Jun 21, 2024

/lgtm

@thesuperzapper
Copy link
Member Author

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 565a740 into kubeflow:notebooks-v2 Jun 21, 2024
3 checks passed
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 23, 2024
@thesuperzapper thesuperzapper deleted the update-crd-specs branch July 15, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants