Add Julius von Kohout as reviewer for /contrib #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kimonas Sotirchos <[email protected]>
|
/approve cancel To wait for feedback |
|
/lgtm |
|
@kimwnasptd are there any specific persons that i should ping for feedback? |
|
/lgtm |
|
/approve |
|
/assign @yanniszark |
|
/lgtm Do you need me to approve? |
|
We are good @james-jwu thanks! Thanks for the feedback everyone! @elikatsis could you merge this PR? |
|
Sure! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elikatsis, jbottum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kevin85421
pushed a commit
to juliusvonkohout/manifests
that referenced
this pull request
Feb 28, 2023
Signed-off-by: Kimonas Sotirchos <[email protected]>
This was referenced Apr 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@juliusvonkohout has been helping on the Manifests WG for a very long time and has done an amazing job on reviews on the
/contribfolder. For this reason I'd like to promote Julius to be a reviewer for the/contribdir.I'm also creating this PR after looking at #2337. I believe that we should have a more granular process of adding someone as an approver in the whole repo and taking iterative steps. The first one is to acknowledge Julius' help on reviews and ensure the OWNERS file represent that. Then move progressively based on the (great!) contributions that will be getting merged.
At the same time I want to ensure that we have a common process for next steps for everyone, and I think kubeflow/community#591 is the best place for this.
Contributions:
cc @kubeflow/wg-manifests-leads