Add license restrictions #1382
Merged
Add license restrictions #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kodiak-appscode[bot]](https://avatars.githubusercontent.com/in/92481?s=60&v=4){kind=small}
ArnobKumarSaha
requested changes
Jan 13, 2025
Comment on lines
19
to
25
| type LicenseConstraints map[string]Restrictions | ||
|
|
||
| type Restrictions struct { | ||
| Constraint string `json:"constraint"` | ||
| // +optional | ||
| Distributions []string `json:"distributions,omitempty"` | ||
| } |
There was a problem hiding this comment.
How about ..
type LicenseRestrictions map[string]Restriction
type Restriction struct {
Constraint string `json:"constraint"`
// +optional
Distributions []string `json:"distributions,omitempty"`
}
LicenseConstraints -> LicenseRestrictions
Restrictions -> Restriction
Not mixing "constraint" & "restriction" stufffs
| if err != nil || !ok { | ||
| return false, err | ||
| } | ||
| if !contains(restriction.Distributions, strDistro) { |
There was a problem hiding this comment.
We can support disrtibution * here.
ArnobKumarSaha
approved these changes
Jan 13, 2025
Signed-off-by: Tamal Saha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.