Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions Failure Due to Missing go-gitlint Tool #120

Closed
wants to merge 2 commits into from
Closed

Fix GitHub Actions Failure Due to Missing go-gitlint Tool #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c76331
feat: Updated scripts/githooks/commit-msg
sweep-ai[bot] Dec 28, 2023
082bc11
feat: Updated scripts/githooks/pre-commit
sweep-ai[bot] Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions scripts/githooks/commit-msg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,15 @@ test "" = "$(grep '^Signed-off-by: ' "$1" |
# TODO: go-gitlint dir set
GITLINT_DIR="./_output/tools/go-gitlint"

if ! command -v $GITLINT_DIR &>/dev/null; then
printMessage "go-gitlint tool not found, attempting to install it..."
make tools || make tools.verify.go-gitlint
if [ $? -ne 0 ]; then
printError "Failed to install go-gitlint. Please manually run 'make tools' or 'make tools.verify.go-gitlint'."
exit 1
fi
fi

$GITLINT_DIR \
--msg-file=$1 \
--subject-regex="^(build|chore|ci|docs|feat|feature|fix|perf|refactor|revert|style|test)(.*)?:\s?.*" \
Expand All @@ -61,8 +70,7 @@ $GITLINT_DIR \

if [ $? -ne 0 ]
then
if ! command -v $GITLINT_DIR &>/dev/null; then
printError "$GITLINT_DIR not found. Please run 'make tools' OR 'make tools.verify.go-gitlint' make verto install it."
printError "Failed to install go-gitlint or go-gitlint tool not found after running 'make tools' or 'make tools.verify.go-gitlint'. Please check the installation process and try again."
fi
printError "Please fix your commit message to match kubecub coding standards"
printError "https://gist.github.com/cubxxw/126b72104ac0b0ca484c9db09c3e5694#file-githook-md"
Expand Down
6 changes: 6 additions & 0 deletions scripts/githooks/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ printError() {
printMessage "Running local kubecub pre-commit hook."

# flutter format .

# Check if go-gitlint tool is installed
if [ ! -x "$GITLINT_DIR" ]; then
printError "go-gitlint tool not found. Please run 'make tools' or 'make tools.verify.go-gitlint'."
exit 1
fi
# https://gist.github.com/cubxxw/126b72104ac0b0ca484c9db09c3e5694#file-githook-md
# TODO! GIT_FILE_SIZE_LIMIT=50000000 git commit -m "test: this commit is allowed file sizes up to 50MB"
# Maximum file size limit in bytes
Expand Down
Loading