Use .Values.kubecostModel.extraEnv #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Any update on this?! |
cliffcolvin
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
This looks good to me, @jessegoodier for a second set of eyes rq
@polarn thank you for the contribution! and @tomodachi for the ping here. We'll get this tested and merged soon and will update you here. |
|
Edit, I was thinking about the wrong repo. |
|
The kubecost cloud docs are here: https://docs.kubecost.com/kubecost-cloud This repo is for that platform. The doc referenced in the PR is for kubecost self-hosted platform. That said, there's no harm in this PR. |
jessegoodier
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
The documentation found here https://docs.kubecost.com/troubleshooting/troubleshoot-install#configuring-log-levels is not correct so this should fix that!