Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support image property under forecasting so ECR only needs to update the base URL, but not the tag #3213

Closed
2 tasks done
pragmaticivan opened this issue Mar 8, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pragmaticivan
Copy link

Problem Statement

When the helm chart is updated and forecasting image is bumped, anyone using the chart with a different registry such as ECr, also needs to bump the forecast image tag, since it only accepts the fullImageName property.

Solution Description

Support image property only for public.ecr.aws/kubecost/kubecost-modeling where the tag is added by the helm chart.

Alternatives

No response

Additional Context

No response

Troubleshooting

  • I have read and followed the issue guidelines and this is a feature request only for the Helm chart.
  • I have searched other issues in this repository and mine is not recorded.
@pragmaticivan pragmaticivan added enhancement New feature or request needs-triage labels Mar 8, 2024
@dwbrown2 dwbrown2 added good first issue Good for newcomers and removed needs-triage labels Mar 13, 2024
@dwbrown2
Copy link
Contributor

@chipzoller @michaelmdresser seems reasonable to be consistent here with other images?

@chipzoller
Copy link
Collaborator

Yes, we should do this.

@chipzoller
Copy link
Collaborator

Superseded by #3280. Closing.

@pragmaticivan
Copy link
Author

All good, but note that this ticket was created before the other one (Mar 27). vs this ticket (Mar 8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants