Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled server-side Secure ETCD and Secure GRPC #28

Closed
wants to merge 5 commits into from
Closed

Enabled server-side Secure ETCD and Secure GRPC #28

wants to merge 5 commits into from

Conversation

seswarrajan
Copy link
Contributor

No description provided.

@seswarrajan seswarrajan linked an issue Dec 7, 2021 that may be closed by this pull request
Secure ETCD connection for KVMSOperator and KVMService #16
Open
nyrahul
nyrahul requested changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please check the comments.

src/service/genscript/genscript.go Show resolved Hide resolved
src/service/server/server.go Show resolved Hide resolved
src/service/server/server.go Show resolved Hide resolved
@seswarrajan
Fixed review comments. Added error handling and returned errors on
329ba52 
respective cases

Signed-off-by: Eswar Rajan Subramanian <[email protected]>
@seswarrajan
Copy link
Contributor Author

Closing this PR as this is a duplicate of #30

#30 is the updated PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nam-jaehyun nam-jaehyun Awaiting requested review from nam-jaehyun

@nyrahul nyrahul Awaiting requested review from nyrahul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Secure ETCD connection for KVMSOperator and KVMService
2 participants
@seswarrajan @nyrahul