-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(logs): add output format option to karmor logs
command
#447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daemon1024
requested changes
Jun 27, 2024
daemon1024
requested changes
Jun 27, 2024
daemon1024
approved these changes
Jun 28, 2024
Can we squash the commits please? Thanks |
navin772
force-pushed
the
karmor-json-pretty
branch
from
June 28, 2024 03:56
b0c5ca3
to
3796a2b
Compare
@navin772 please rebase with upstream main once to fix the failing tests. |
daemon1024
approved these changes
Jul 24, 2024
@DelusionalOptimist all the tests are now passing. |
Please squash the commits 🙌 Rest LGTM |
Signed-off-by: Navin Chandra <[email protected]>
navin772
force-pushed
the
karmor-json-pretty
branch
from
July 24, 2024 12:07
e869d6a
to
94f4635
Compare
@daemon1024 can you rebase and merge the PR, having some issues with squashing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #439
Introduced new flags for pretty and normal printing:
karmor logs --output json
karmor logs --output pretty-json
karmor logs --output text
Shorthand ->
-o
The
--json
flag is still present:karmor logs --json
Output: