fix: update graphql base on GRL_SDK_GENERATOR_IMAGE update #324
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abirdcfly <[email protected]>
|
@dayuy @Carrotzpc pls review |
Carrotzpc
approved these changes
Dec 4, 2023
|
@Carrotzpc We should avoid using hard coded endpoint in bff sdk. Maybe optimize this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it
After yuntijs/bff-sdk-generator#5 is meged, image is updated, so we need to update the parameters that use the image.
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer